-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Clear plaid data when trying to enable wallet #32949
Conversation
Reviewing shortly |
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2023-12-13.at.03.07.36.mp4CleanShot.2023-12-13.at.03.10.35.mp4Android: mWeb ChromeCleanShot.2023-12-13.at.02.37.09.mp4iOS: NativeCleanShot.2023-12-13.at.03.47.57.mp4iOS: mWeb SafariCleanShot.2023-12-13.at.03.44.33.mp4MacOS: Chrome / SafariCleanShot.2023-12-13.at.03.41.11.mp4MacOS: DesktopCleanShot.2023-12-13.at.01.53.43.mp4CleanShot.2023-12-13.at.02.00.11.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this for me, @luacmartins! 🙇
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Clear plaid data when trying to enable walelt (cherry picked from commit 124db72)
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.11-25 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀
|
Details
Uses existing method to clear plaid data when selecting
Enable wallet
Fixed Issues
$ #32906
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
web.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop